openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Renaming Subject

Open bitnapper opened this issue 1 year ago • 6 comments

Problem

Many subject have multiple different duplicate, e.g. Ernest Rutherford (1871-1937), Rutherford, ernest, 1871-1937

Subject page has an edit button that could be facilitated to rename that subject in any edition

image

Example:

Go to subject page Rutherford, ernest, 1871-1937, Edit-Button, change title from Rutherford, ernest, 1871-1937 to person:Ernest Rutherford (1871-1937), save button.

After saving, the subject should be changed in all edition with the former subject.

Proposal & Constraints

What is the proposed solution / implementation?

see above.

Is there a precedent of this approach succeeding elsewhere?

not to my knowledge.

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

Leads

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

bitnapper avatar Aug 10 '24 11:08 bitnapper

@bitnapper Can you assign this issue to me?

AbhinavKRN avatar Aug 10 '24 14:08 AbhinavKRN

@bitnapper Can you assign this issue to me?

@AbhinavKRN I'm sorry, I don't have any special permissions to do that. I guess @mekarpeles can do that?

bitnapper avatar Aug 10 '24 15:08 bitnapper

@mekarpeles @gojomo can you assign this issue to me? I can easily solve this issue and raise the PR soon !!

charanbhatia avatar Aug 10 '24 19:08 charanbhatia

I would recommend waiting until the issue is triaged to see what they'd like the solution to be. Personally, I think the right solution is to make subjects into 1st class objects instead of mere strings, as I suggested in #2819. Then all the different name variants (and different language labels) can get stored as aliases.

tfmorris avatar Aug 10 '24 20:08 tfmorris

Just chiming in to add that because #9520 / #9643 uses subjects, improvements in subjects (e.g. such as outlined in #2819 and #7904) would probably make the Best Book feature more useful to patrons.

scottbarnes avatar Aug 10 '24 21:08 scottbarnes

Related to #7904 and #65

mekarpeles avatar Aug 19 '24 19:08 mekarpeles