openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Standardize Styling for Search Inside Results

Open merwhite11 opened this issue 6 months ago • 2 comments

Closes #9479

  • Updates styling to Search Inside Result to match the Search Inside Suggestion Card #1001
  • Eliminates inconsistent footer messages.

Technical

Merged in #9734 and combined the fulltext-suggestion-snippet.less to fulltext-snippet.less.

When this PR gets merged in, there will be a merge conflict in page-user.less where the snippet styling files are being imported.

I will need to resolve the conflict so that both FulltextSuggestionSnippet.html and FulltextSnippet.html are styled by fulltext-snippet.less from this PR.

Testing

I tested this by using a sample data json and a reference to the json in dev env: https://github.com/jimchamp/openlibrary/compare/master...jimchamp:openlibrary:sandbox-fulltext-search-results#diff-fb7667454719879be914be81c253b5dd9fc0dcbdb6afaada791b5091e80e8ec2

I input the test data to the web container by running these commands: docker compose exec -e PYTHONPATH=. web bash ./scripts/copydocs.py /books/OL24966433M ./scripts/copydocs.py /books/OL32090209M ./scripts/copydocs.py /books/OL24375865M ./scripts/copydocs.py /books/OL24204364M ./scripts/copydocs.py /books/OL7522718M

The test search term is 'a cricket in the night'

Screenshot

Screenshot 2024-07-30 at 12 08 24 PM

Stakeholders

@mekarpeles

merwhite11 avatar Jul 30 '24 19:07 merwhite11