openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Show popup warning to librarians when they've populated fields that have an "add" button but forgot to use the button

Open bilch opened this issue 1 year ago • 12 comments

Problem

Most form fields on work, edition or author pages are just saved when I click "save". However, some fields (e.g. add link to work) have an additional "add" button that needs to be clicked before saving. I keep forgetting to use that button, and the input to that form field is lost.

A clear and concise description of what you want to happen

Whenever I populate a form field that has an "add button" and then save that page without having used the "add" button, I would like to see a warning.

Expected behaviour / screenshots (ex: Figma design screenshots for UI feature)

Additional Context

Proposal & Constraints

What is the proposed solution / implementation?

Show a popup warning whenever a form field with an add button has been populated but not saved. Or maybe just save the content, if that is possible.

Is there a precedent of this approach succeeding elsewhere?

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

Leads

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

bilch avatar Jul 10 '24 14:07 bilch

hey @jimchamp I would like to work on this issue. can you please assign this to me ?

deysandip301 avatar Jul 12 '24 06:07 deysandip301

@bilch can you assign this issue to me?

AbhinavKRN avatar Jul 19 '24 18:07 AbhinavKRN

@mekarpeles I'd like to work on this issue

UtkershBasnet avatar Jul 24 '24 15:07 UtkershBasnet

@rebecca-shoptaw can you assign this issue to me?

AbhinavKRN avatar Jul 26 '24 18:07 AbhinavKRN

@AbhinavKRN That's always a good question for the issue's lead, which you can see in the "Labels" section is @jimchamp 🙂

rebecca-shoptaw avatar Jul 26 '24 18:07 rebecca-shoptaw

@jimchamp can you assign this issue to me?

AbhinavKRN avatar Jul 26 '24 19:07 AbhinavKRN

Hii @jimchamp if this still issue is still not resolved, can you assign it to me? Thank you

smitrami-123 avatar Aug 19 '24 18:08 smitrami-123

@AbhinavKRN, can you give a progress update? If you are no longer able to work on this issue, let me know so I can reassign it.

jimchamp avatar Aug 21 '24 00:08 jimchamp

Her @jimchamp , i want to work on this issue

Suswetha6 avatar Aug 26 '24 13:08 Suswetha6

No word from @AbhinavKRN, so I'm assuming that this is not being worked on. Are you still interested in working on this, @smitrami-123?

jimchamp avatar Aug 28 '24 01:08 jimchamp

Hii @jimchamp I am interested working on the issue. You can assign it to me. Thank you

smitrami-123 avatar Aug 28 '24 17:08 smitrami-123

Just a quick question, is it still a good first issue? because I am new to open source contribution

smitrami-123 avatar Aug 28 '24 17:08 smitrami-123

@smitrami-123, this may be a good first issue, but as of now I don't think that there is enough information here for anyone to solve the issue.

In the near future, I'll update this issue with additional requirements and a list of files that will likely require changes. Until then, I'll abstain from assigning this issue to a contributor.

jimchamp avatar Aug 30 '24 23:08 jimchamp