internetarchive
Investigate removing the `waitingloan` table
Problem
As @cdrini identified in https://github.com/internetarchive/openlibrary/pull/9404, the waitingloan table might be unused now that /admin/waitinglist has been removed.
Proposal & Constraints
Verify if this is the case, and remove the waitingloan table and all associated code if so.
Leads
Related files
Stakeholders
@cdrini
Note: Before making a new branch or updating an existing one, please ensure your branch is up to date.
(I can't assign labels but this is likely a good first issue candidate)
I would like to investigate on this and work on this, kindly assign this issue
Hi! @cdrini can I work on this? I'm new here and this seems like the perfect first issue
Hey @cdrini ,
I've noticed that the waiting loan appears to be unused. I would like to investigate this further to confirm if it's indeed unused and, if so, proceed with removal of this and it's associated codes.
Could you please assign this issue to me? Thank you!
Hi @cdrini,
It appears that the waiting loan feature isn't being used. I'd like to look into this to confirm, and if it's true, I'll remove the feature and its related code. Could you please assign this issue to me?
Thanks!
Howdy @Jash2606 ! Hm I think something went wrong with your PR; if you're still interested in working on it, please feel free to re-open it! It looked mostly correct; I think you just deleted one extra class :P
Hello @cdrini ! I saw that the last attempt to resolve this issue accidentally deleted an extra class – I have implemented the required changes (removing waitingloan table and associated code) while preserving the waitingloan class. May I be assigned this issue?
Staff is necessary to remove the tables, so I'm not sure why this was labeled Good first issue.
@sophiazhuu, I'll be happy to merge your PR whenever the Python code removals have been restored (include only the waitingloan DDL removals in the PR). The code that was removed calls an IA API, and does not query our DB.