openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

change made to address issue #7073, add original publication date

Open JerryLi00 opened this issue 1 year ago • 1 comments

Closes #7073

Adds a feature for adding the original publication date when adding works via the add work form

Technical

The feature is currently completely optional and has no input validation

Testing

Ran with automated tests and linting, also would require user testing via trying the add new work form.

Screenshot

Screenshot 2024-04-25 at 9 46 30 PM Screenshot 2024-04-25 at 9 46 36 PM

Stakeholders

@FinixFighter

JerryLi00 avatar Apr 26 '24 01:04 JerryLi00

FYI there is a documented property first_publish_date on works here: https://openlibrary.org/type/work

The example from #7073 , https://openlibrary.org/works/OL17449W.json already has this property set. Unfortunately it's currently: October 28, 2007 , which is clearly wrong.

The language around the issue (and associates first publish date with the work, which is appropriate, but the code in this PR appears to be setting original_publish_date on the edition record.

hornc avatar May 07 '24 13:05 hornc