openlibrary
openlibrary copied to clipboard
internetarchive
Add share links to author pages
Describe the problem that you'd like solved
It's more cumbersome to share author pages than it could be. Today, the URL most be copied manually, then shared with others.
Proposal & Constraints
Other pages, like the books page, contain a share modal that gives a number of options for sharing links. Let's add this to author pages, as well.
Additional context
This is related to #452, which is primarily concerned with adding a QR code option to the share modal. This issue was created to reduce the scope of the aforementioned issue.
Stakeholders
@LeadSongDog
Hello, i am currently new to contributions and i am interested in working on this issue. Could you please provide more info on where the share modal should be?
The link for the share modal can go on the top-right corner of the view, to the right of the "Edit" button. You can use the same image and styling as the book page share link:
Searching for ShareModal in .html files will give insight into how our share modals are added to other pages.
The link for the share modal can go on the top-right corner of the view, to the right of the "Edit" button. You can use the same image and styling as the book page share link:
Searching for
ShareModalin.htmlfiles will give insight into how our share modals are added to other pages.
Hello, i really appreciate the response and i will be working on the issue the following days. I ll let u know soon!
may i take this issue?
No @ManavSarkar, it has already been assigned to somebody else.
@mekarpeles @jimchamp Hello! I wanted to give an update on this issue. I think it is almost done, we are just waiting on a feedback.You can check our modification on my branch (https://github.com/aggelasdinou/openlibrary/tree/9141/feature/add_shareModal_authors). Also, as i am working together with @Tzinapapadopoulou , is it possible to add her as an assignee?
Hi @aggelasdinou. If the branch is ready for feedback, please open a pull request.
Unless a contributor has elevated access to a repository, they can't be added as an assignee to an issue until they have commented on the issue thread.
Hello, we are still working on it. Actually, we have adjust our changes to the mobile version. Can you add me as an assignee? @jimchamp
@Tzinapapadopoulou and @aggelasdinou, @jimchamp is away currently but will review the associated PR when he gets back. In the interim, I've added you as an assignee, @Tzinapapadopoulou.
The issue is still open. The linked PR will solve the issue, but needs to be updated by the original authors.
