openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Remove mailing lists heading from about page

Open noobCoderVP opened this issue 1 year ago • 7 comments

Closes #9080

fix

Technical

Removing the mailing list heading image

Testing

Test it before merging because I am getting below error in local dev environment image

Screenshot

Stakeholders

noobCoderVP avatar Apr 21 '24 06:04 noobCoderVP

I think we only want the changes to openlibrary/templates/type/about/view.html and not infogami

mekarpeles avatar Apr 22 '24 12:04 mekarpeles

Yup @noobCoderVP you can just remove the infogami changes and then we are good to go. That page doesn't show up on your local instance because it isn't in the local instance testing data.

Edit: more info about the infogami files here https://internetarchive.slack.com/archives/C0ETZV72L/p1713794942035489?thread_ts=1713792574.458309&cid=C0ETZV72L

RayBB avatar Apr 22 '24 14:04 RayBB

Hey @RayBB could you help me remove the infogami changes? I tried everything like git restore --staged & git reset --hard but I am not able to figure it out, please help me out

noobCoderVP avatar Apr 26 '24 06:04 noobCoderVP

@noobCoderVP can you try cding into the infogami directory and then doing a git reset? Then leave again and commit the changes.

RayBB avatar Apr 26 '24 14:04 RayBB

@noobCoderVP, if that doesn't work, you can try:

git reset --soft bee8ab4e369a500e1e31f73d3f06fb88e7c5896f
git restore --staged vendor/infogami
make git
git commit

If you do git log -p first you can look at the commit hashes to see where you're resetting to, and if you do git status at each step it may make more sense about what's happening. As for make git, see the git entry in Makefile to see what that's actually doing.

scottbarnes avatar Apr 26 '24 20:04 scottbarnes

@noobCoderVP did Scott's instructions work okay for you?

RayBB avatar May 02 '24 10:05 RayBB

I need to check that out @RayBB, got busy with university's final exams. Will do that tonight, sorry for the delay

noobCoderVP avatar May 02 '24 12:05 noobCoderVP

@RayBB I have fixed it! again sorry for the delay

noobCoderVP avatar May 11 '24 04:05 noobCoderVP