openlibrary
openlibrary copied to clipboard
internetarchive
On account create page “Each field is required” msg should disappear if on submit all fields have values
Problem
Patrons are confused when signing up and report this as an error. If all fields are completed the requirement message should no longer be visible.
Evidence / Screenshot
Relevant URL(s)
https://openlibrary.org/account/create
Reproducing the bug
- Go to ...https://openlibrary.org/account/create
- Do ...complete all fields
- Expected behavior: If all fields are completed, there should be no error message in red.
- Actual behavior: Each field is required remains visible.
Context
- Browser (Chrome, Safari, Firefox, etc):
- OS (Windows, Mac, etc):
- Logged in (Y/N): Y
- Environment (prod, dev, local): prod
Notes from this Issue's Lead
Proposal & constraints
Related files
Stakeholders
Yes, of course! For reference, the template for the registration form is here. The client-side validation code for registrations can be found here.
Recently, the Open Library team met to revamp #2055 which describes what changes we'd like to see done to the Registration page.
@jimchamp and I would like this project to be led by @rebecca-shoptaw.
The Requirements include:
- [ ] If you put in an email that is taken, we find out right away without form submit
- [ ] If all fields are entered, we shouldn’t show an error that says “all fields required”
- [ ] We need to communicate that screen name is public
- [ ] We need to show right away whether a screenname is taken and possibly suggest an available one (right now it’s hard because an OL screenname may be available, but I don’t think we also check archive.org)
- [ ] Clicking submit/pressing enter, any empty fields will be highlighted red, and the error text next to the field will say “This field is required”
@rebecca-shoptaw you may find it easiest to create separate issues for some of these difference pieces. Can we make you the Lead of this issue and #2055 and then see if contributors (e.g. @camicacace) may be able to help us do parts of this work?
Sorry in advance @camicacace for the confusion, let's try and wait for @rebecca-shoptaw to have a chance to go through this project and organize it so we know the best way for you to help out!
Sounds great to me!
This part of the project should work quite well as a stand-alone contribution, and I'm happy to handle any resulting merge conflicts on my end and/or help @camicacace ensure everything is up to date, depending on which parts of the project are finished first.
I'll be available to answer any questions here or on Slack! Good luck @camicacace 🙂
@devansh-dek Good catch! This issue was actually completed as part of the registration UI overhaul (#9316) which removed the text entirely, but if you're looking for a good first issue, there should be a number open now or opening soon.
Issue resolved (relevant text removed from form entirely) in #9316.