openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Remove `/admin/waitinglists` page

Open mekarpeles opened this issue 1 year ago • 2 comments

Problem

https://openlibrary.org/admin/waitinglists frequently times out because there's too many records and too many queries per record.

The page is presumably supposed to return a list of all books with waitinglists.

Check with @seabelis if this page is needed as I know we have a separate dashboard for Archive.org

image

One workaround is limiting the number of books returned, which has been tested by #9059 and works on testing

Evidence / Screenshot

Relevant URL(s)

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders

mekarpeles avatar Apr 10 '24 16:04 mekarpeles

I've only ever used the one on archive. I'm not sure I knew about this one.

seabelis avatar Apr 10 '24 16:04 seabelis

I think we may be able to remove this admin endpoint entirely as the source of truth for checking waitlists is now the archive.org/services/loans API

mekarpeles avatar Apr 10 '24 16:04 mekarpeles

Could I take this issue on, please? 😊

pidgezero-one avatar Jun 02 '24 01:06 pidgezero-one

@pidgezero-one, go for it! Let me know if you have any questions about anything.

jimchamp avatar Jun 04 '24 20:06 jimchamp

Thanks @jimchamp !

My only question so far: does this ticket strictly remove admin/waitinglists (and associated code used only for that page), or does it also need to remove all waiting list code entirely (such as the WaitingLoan class)?

pidgezero-one avatar Jun 06 '24 02:06 pidgezero-one

@pidgezero-one, the scope of this issue is limited to removing the admin/waitinglist page and the code associated with it.

jimchamp avatar Jun 10 '24 13:06 jimchamp

Thank you for the clarification @jimchamp ! My PR only covers that scope.

pidgezero-one avatar Jun 10 '24 13:06 pidgezero-one