openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Delete some unused templates discovered by i18n process

Open cdrini opened this issue 1 year ago • 6 comments

Delete these files and anything that they call that is only called by them. It is no longer possible to edit macros from the openlibrary.org website.

  • openlibrary/macros/EditButtonsMacros.html
  • openlibrary/templates/type/macro/*
  • openlibrary/templates/type/rawtext/*
  • openlibrary/macros/SRPCoverImage.html
  • openlibrary/macros/databarAuthor.html
  • openlibrary/templates/admin/profile.html
  • openlibrary/templates/lib/markdown.html

For each:

  • Note other macros/templates referenced in the html file. Are they only referenced by the files we are deleting? If so delete it as well
  • Search the codebase for the name of the file. Remove any CSS or CSS comments
  • Search the codebase for the name of the file. Remove any code (not necessarily entire file) that references the given file.

Stakeholders

@merwhite11

cdrini avatar Apr 09 '24 20:04 cdrini

Hi there! I suppose I can tackle this issue, is there any chance that I can work on it?

Spedi avatar Apr 10 '24 14:04 Spedi

Hi @Spedi ! Go for it :) Let me know if you have any questions!

cdrini avatar Apr 11 '24 02:04 cdrini

I was starting to tackle this issue, should I also delete the references of the templates on the .po files?

Spedi avatar Apr 14 '24 19:04 Spedi

At the end of the deletions, generate the pot file; that should be enough!

cdrini avatar Apr 14 '24 22:04 cdrini

Hi @Spedi I'm going to take this one; it's a little higher priority since I don't want translators to accidentally translate the strings here since they won't be used!

cdrini avatar May 01 '24 23:05 cdrini

Hi there @cdrini! Don't worry, and I'm sorry I didn't make any PR, I probably shouldn't have taken too many issues on my back :)

Spedi avatar May 02 '24 10:05 Spedi

This is priority 2 because otherwise translators will translate strings we don't actually need :+1:

cdrini avatar May 10 '24 19:05 cdrini