openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

made correction on reading logs page when no matches found

Open Ayush1404 opened this issue 1 year ago • 1 comments

Closes #8811

Searches on the reading log with no matches incorrectly show the "No books on this shelf" screen, this PR fixes it by showing correct error messages and other changes mentioned in issue #8811.

Technical

Testing

z
  1. Go to one of your reading log shelves (eg https://openlibrary.org/people/ScarTissue/books/already-read )
  2. Perform a search for something that won't match (eg "foo bar")
  3. See the output and then check thr search facility by going to "Search all of Open Library for "{query}"?" button .

Screenshot

Screenshot from 2024-02-11 00-13-57

Stakeholders

@cdrini

Ayush1404 avatar Feb 10 '24 19:02 Ayush1404

Hey @cdrini and @jimchamp, thank you very much for reviewing my code, I have made the necessary corrections that you suggested, can you please review if these are the changes you expected, thanks in advance :)

Ayush1404 avatar Feb 24 '24 01:02 Ayush1404