openlibrary
openlibrary copied to clipboard
Implementation of new My Lists Design
Closes #7704
Technical
This pull request refactors code from #7743, and adds a new section of mybooks where a user's first three lists are graphically previewed. The list object in openlibrary/core was given a new method that caches a small dictionary with memcached for up to ten minutes, containing a dict with near-minimal data for each list.
Testing
Simply create a list, and navigate to your 'My Books' page. Importantly, there are some situations in which covers will not load; certain methods of adding a book to one's list add a Work
, rather than an Edition
. Works seem to rarely have associated covers, so will rarely display correctly. I was advised that solving that is outside of the scope of this Pull Request, so I'll merely be documenting my currently known methods.
Currently known ways that add a work;
- The edit UI of the list.
- The Solr Book Search
Currently known ways that add an edition: -navigating to an edition page, and manually adding the book via the 'want to read' dropdown.
Screenshot
Stakeholders
@mekarpeles
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 16.01%. Comparing base (
d376947
) to head (ddbdf60
). Report is 217 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #8725 +/- ##
==========================================
- Coverage 16.62% 16.01% -0.62%
==========================================
Files 88 89 +1
Lines 4698 4696 -2
Branches 837 820 -17
==========================================
- Hits 781 752 -29
- Misses 3399 3436 +37
+ Partials 518 508 -10
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Heads up @cdrini, you may wish take into account the PR found here: #7743.
This one may need to be rebased, I'm seeing a lot of pyc files checked in!