openlibrary
openlibrary copied to clipboard
internetarchive
Added: Highlighted staged changes in BulkTagger
Closes #8658
This PR addresses the issue outlined in #8658 by enhancing the Bulk Tagger tool to provide visual indications of subjects staged for addition or removal. The proposed solution adds highlighting to the corresponding menu options when a subject is staged.
Technical
The PR integrates the highlighting logic to the staged changes for addition or removal. The highlighting classes are applied based on the updated menu option state. I still have some queries regarding the staged changes as mentioned here
Testing
-
Open Manage Subjects Menu
-
Add / Remove subject to view highlighted staged changes
Screenshot
Before Staging changes
After Staging changes
Stakeholders
@jimchamp
If this is ready for review, press the "Ready for review" button. Is it ready for review? I said that there should only be yellow highlighting in this comment, but I see both yellow and grey highlighting in your screenshots...
If this is ready for review, press the "Ready for review" button. Is it ready for review? I said that there should only be yellow highlighting in this comment, but I see both yellow and grey highlighting in your screenshots...
Yeh I added grey highlighting to highlight the removed changes and yellow for the addition. I can revert the highlight color for removed to yellow :) @jimchamp
@jimchamp I have made this PR ready for review. If you want me to revert the color of "removed" changes to yellow instead, Ill make a commit :+1:
Codecov Report
Attention: 16 lines in your changes are missing coverage. Please review.
Comparison is base (
71b18af) 16.66% compared to head (4f53ae6) 16.60%. Report is 57 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| ...y/plugins/openlibrary/js/bulk-tagger/BulkTagger.js | 0.00% | 15 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #8676 +/- ##
==========================================
- Coverage 16.66% 16.60% -0.06%
==========================================
Files 88 88
Lines 4686 4702 +16
Branches 835 839 +4
==========================================
Hits 781 781
- Misses 3389 3404 +15
- Partials 516 517 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
