openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Implement "see all" button for carousels on my books page

Open danafein opened this issue 2 years ago • 12 comments

We would like to implement a "see all >" button on the right-hand side of each carousel on the my books page, as pictured here:

Screen Shot 2023-03-22 at 1 58 59 PM

The specific changes from the current version are:

  • Changing the color of the heading text for each section (loans, currently reading, want to read, and already read) to the same gray as the heading "My Books" text at the top
  • Removing the underline from the heading text for each section
  • Adding text that says "SEE ALL >" to the right of the heading for each section
  • Making the entire header bar for each section clickable, so that if a user clicks anywhere between the heading title (e.g. currently reading) and the "see all" button, they still get redirected to the page for that section

For any clarifying questions about the changes to the design, please reach out to @danafein.

Stakeholders

danafein avatar Mar 22 '23 18:03 danafein

Hello @danafein, could you please assign this issue to me? I am interested in working on it.

Ari1009 avatar Mar 23 '23 02:03 Ari1009

@Ari1009 I just assigned it to you! Thank you for working on it!

danafein avatar Mar 23 '23 21:03 danafein

Is anyone working on this issue ?

gauravtak avatar Apr 17 '23 23:04 gauravtak

@Ari1009 had expressed interest in working on this issue. @Ari1009, are you still working on this issue? The two of you could also work together!

danafein avatar Apr 19 '23 14:04 danafein

Ok, I have no issues working on this together if @Ari1009 allows it. But if the issue solved already that's fine.

gauravtak avatar Apr 19 '23 14:04 gauravtak

@gaurav-2-0-0-2 all yours if you'd like to give it a try!

mekarpeles avatar Sep 16 '23 19:09 mekarpeles

Can i work on this?

tushdemort avatar Sep 19 '23 18:09 tushdemort

I want to work on this. Please assign me this issue.

ayushman075 avatar Dec 25 '23 13:12 ayushman075

what's the status of the merge? does @tushdemort have to resolve conflicts?

wright-benjamin-1701 avatar Jul 10 '24 03:07 wright-benjamin-1701

I want to work on this.Please assign it to me.

siddharthbaleja7 avatar Jul 16 '24 07:07 siddharthbaleja7

@siddharthbaleja7 still interested? I am too!

wright-benjamin-1701 avatar Aug 14 '24 22:08 wright-benjamin-1701

Please assign me this issue.

wright-benjamin-1701 avatar Aug 20 '24 13:08 wright-benjamin-1701

I would still like to be assigned this issue. @danafein there are other carousels that use this same custom_carousel template. would you like those to be updated as well? how about any updates to the mobile version?

wright-benjamin-1701 avatar Dec 15 '24 18:12 wright-benjamin-1701

I think now that each section is a link in desktop (and because we have other carousels elsewhere which we want to present consistently) I'm going to close this issue for now, sorry!

mekarpeles avatar Jan 13 '25 00:01 mekarpeles