openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

/works/OL1W?edition=* should redirect to new Work if edition has moved

Open cdrini opened this issue 2 years ago • 7 comments

Evidence / Screenshot (if possible)

Relevant url?

eg https://openlibrary.org/works/OL17495436W?edition=ia%3Aherfirefighterun0000unse Should redirect to https://openlibrary.org/works/OL33218807W/Her_Firefighter_Under_The_Mistletoe_Snowbound_with_Dr._Delectable?edition=herfirefighterun0000unse?edition=ia%3Aherfirefighterun0000unse

Steps to Reproduce

  1. Go to https://openlibrary.org/works/OL17495436W?edition=ia%3Aherfirefighterun0000unse
  • Actual: Page pretends the editions is associated with this work
  • Expected: Redirected to correct work

Details

  • Logged in (Y/N)? N
  • Browser type/version? FF108
  • Operating system? Win10
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

@seabelis

cdrini avatar Jan 06 '23 16:01 cdrini

Hello! Is this ticket still available and can I help?

smherda avatar Jan 28 '23 05:01 smherda

@cdrini Hi! I am Tushar, a first-year student at BITS Hyderabad, India. I am interested in working on this issue, however, could you please elaborate a bit on the issue?

tushdemort avatar Mar 09 '23 17:03 tushdemort

@tushdemort @smherda Hi, are you guys still looking to work on this issue?

JaydenTeoh avatar Mar 15 '23 10:03 JaydenTeoh

@cdrini I'd like to work on this issue, any pointers?

akhil-rasheed avatar Sep 19 '23 10:09 akhil-rasheed

@JaydenTeoh Hello! I didn't get any feedback on this, so the ticket is still open. Feel free to work on it.

smherda avatar Sep 20 '23 13:09 smherda

Hi @mekarpeles, I can start working on this, if you can assign the issue. Any pointers would be appreciated as well!

akhil-rasheed avatar Sep 21 '23 15:09 akhil-rasheed

Hello! @cdrini, @mekarpeles

I am trying to resolve this issue.

But I needed some clarifications:

  1. Does every "work" have a unique "Internet Archive" number?
  2. Why https://openlibrary.org/works/OL17495436W?edition=ia%3Aherfirefighterun0000unse Should redirect to https://openlibrary.org/works/OL33218807W/Her_Firefighter_Under_The_Mistletoe_Snowbound_with_Dr._Delectable?edition=herfirefighterun0000unse?edition=ia%3Aherfirefighterun0000unse ? Why can't https://openlibrary.org/works/OL17495436W?edition=ia%3Aherfirefighterun0000unse redirect to https://openlibrary.org/works/OL17495436W ?
  3. Can "internet archive" number(or "edition", I am asssuming) for a "work" be changed?

I know I can answer these questions by looking at the code. But please help me a little.

kushagra0304 avatar Feb 14 '24 08:02 kushagra0304

Hello! @cdrini, @mekarpeles

I am trying to resolve this issue.

But I needed some clarifications:

1. Does every "work" have a unique "Internet Archive" number?

2. Why [https://openlibrary.org/works/OL17495436W?edition=ia%3Aherfirefighterun0000unse](url) Should redirect to [https://openlibrary.org/works/OL33218807W/Her_Firefighter_Under_The_Mistletoe_Snowbound_with_Dr._Delectable?edition=herfirefighterun0000unse?edition=ia%3Aherfirefighterun0000unse](url) ?
   Why can't [https://openlibrary.org/works/OL17495436W?edition=ia%3Aherfirefighterun0000unse](url) redirect to [https://openlibrary.org/works/OL17495436W](url) ?

3. Can "internet archive" number(or "edition", I am asssuming) for a "work" be changed?

I know I can answer these questions by looking at the code. But please help me a little.

To answer question 2, the specific edition of the book is a two in one book with an extra story by Susan Carlisle. They are qualitatively different books. That book is unique and the search results should reflect that.

I'm personally still trying to wrap my head around the code base but I think changing whatever SQL statement handles the generation of editions to include a like clause the would filter out the single story version of the book could help.

Again I'm still trying to figure out how the ORM and MVC pattern for this site works, so If I'm off base I apologize

OmarEid451 avatar Mar 26 '24 21:03 OmarEid451

Questioning to see if I could work on this?

psyren99 avatar Jun 02 '24 19:06 psyren99