Author not added to work if neither the pop-up author name, nor "Create a new record for" is selected on /books/add

[scottbarnes]

When entering a book via http://localhost:8080/books/add, the text entered into the "Author" field is only added to the book's record if the patron clicks on the pop-up for (1) the existing author name, if the author exists, or (2) "Create a new record for" if the author does not exist.

For people typing quickly or using tab on the keyboard to switch fields, it can be easy to overlook clicking on those, as nothing prevents one from entering an author name, not clicking one of the pop-ups, and then clicking "Add"; in this case the author entered in the author field will be absent from the work.

Evidence / Screenshot (if possible)

Adding a new author fails without clicking one of the pop-ups in the author field

Adding a new book with a new author, without clicking on the pop-up to select an existing author or to create a new one:

With all the fields completed as above, the HTML for the form has not updated to include the author name, yet one can add the book, even with <input id="author-0-key" ... value=""

Note: for all of these I realize I should have changed the highlighted field, as in each case the HTML to which I am referring is immediately below the highlighted text:

The book now lacks an author:

How it should look

Adding an author and clicking the pop-up in the author field will properly update the form data:

Here, the <input id="author-0-key" ... value="__new__" is properly set:

As a result, the author new author is added to the work:

This error also happens with existing authors

Adding a new book for Daniel Defoe, but not clicking on his name in the pop-up:

His author ID is not entered in input_id="author-0-key" ... value="">

And it does not show up in the work:

But if his name is clicked, input_id="author-0-key" ... value="/authors/OL18283A"> shows up:

Relevant url?

http://localhost:8080/books/add or https://www.openlibrary.org/books/add

Steps to Reproduce

1. http://localhost:8080/books/add
2. Add an existing or new author, but do not click a pop-up with the existing author name, or to create a new record.
3. Click "Add"
4. The "Author" field in the created work will be empty.

• Actual: The author in the author input box on /books/add is not added to the work.
• Expected: The author in the author input box on /books/add is added to the work.

Details

• Logged in (Y/N)? Y
• Browser type/version? Firefox 103.0.2 (64-bit)
• Operating system? Manjaro: 5.19.1-3-MANJARO
• Environment (prod/dev/local)? dev

Proposal & Constraints

I propose there be some sort of constraint (along with visual feedback about what's wrong) that prevents a patron from both filling out the author field and clicking "Add" on /books/new without also clicking the pop-up to either create a record for an author or to select an existing author.

Related files

Stakeholders