openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Editing - Submit button should be disabled till google verifies recaptcha.

Open muditjuneja opened this issue 2 years ago • 2 comments

When editing a book, the save button at the end should be disabled till the google verifies recaptcha entry. Currently, it is clickable which takes the user to another error screen. Check the screenshots attached.

Evidence / Screenshot (if possible)

Relevant url?

https://openlibrary.org/books/OL23245221M/Catch-22/edit

Steps to Reproduce

  1. Log in
  2. Go to any book and click edit
  3. Scroll down and click submit, it lets you click
  • Actual - It takes the user to an error screen saying invalid captcha
  • Expected - Button should be disabled till the user is verified as a human

Details

  • Logged in (Y/N)? Y

Proposal & Constraints

Button should be disabled till the user is verified as a human

Stakeholders

Screenshot 2022-08-22 at 5 03 13 PM Screenshot 2022-08-22 at 5 03 23 PM

@cdrini

muditjuneja avatar Aug 22 '22 11:08 muditjuneja

This could interfere with the trusted-users feature (see #4998) (I only bring it up, because I don't see a CAPTCHA at all which I guess means I might be a "trusted-user").

agmckee avatar Aug 22 '22 12:08 agmckee

@agmckee, I see but we can add a conditional check for the same on the front-end like if the user doesn't have a "trusted-user" tag (a normal user) then he should verify as human to enable the button.

muditjuneja avatar Aug 22 '22 17:08 muditjuneja