openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Add pending merge request badge count

Open SyedMa3 opened this issue 3 years ago • 3 comments

Closes #6811

Feature - Added a bubble to the avatar and then a entry + bubble into the sub-navigation within the hamburger.

Technical

  • The bubble is only visible when admin/super-librarians have atleast one pending merge requests.

Testing

https://gist.github.com/jimchamp/dd83ae3fe1ea86ae9621707fa96b4edf Execute these commands and you can see the bubble.

Screenshot

image Avatar image Hamburger List

Stakeholders

SyedMa3 avatar Aug 07 '22 13:08 SyedMa3

Thanks for submitting this contribution!

mekarpeles avatar Aug 07 '22 18:08 mekarpeles

@mekarpeles What does it mean by Needs: Submitter Input? Do I need to specify something? This is my first open source contribution so I don't know the process.

SyedMa3 avatar Aug 09 '22 07:08 SyedMa3

@mekarpeles What does it mean by Needs: Submitter Input? Do I need to specify something? This is my first open source contribution so I don't know the process.

Staff members typically add the Needs: Submitter Input label to PRs that have been reviewed, but need some changes from the contributor. I think that we didn't notice that you pushed the requested changes, and added the label in error. Apologies!

jimchamp avatar Aug 10 '22 01:08 jimchamp

Noticed a few small improvements that could be made since I last reviewed this. Those changes have been committed. Thanks for your contribution, @SyedMa3!

jimchamp avatar Aug 15 '22 15:08 jimchamp

@jimchamp Thanks for patiently helping and suggesting improvements.

SyedMa3 avatar Aug 15 '22 16:08 SyedMa3