openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Clicking “Related Books” jumps down too far; causes nav bar to disappear

Open mekarpeles opened this issue 3 years ago • 4 comments

Whenever a patron clicks on a book page navbar link, the navbar partially obscures the section that they have navigated to. A patron must scroll up a small amount to see the section's header.

Evidence / Screenshot (if possible)

desktop Desktop view

mobile_jump_link Mobile view

Relevant url?

Any edition or work page.

Steps to Reproduce

  1. Go to any edition or work page.
  2. Click on a navbar link.
  3. Observe the page after the scrolling has stopped.
  • Actual: The top of the target section is obscured by the navbar.
  • Expected: The navbar rests neatly above the target section.

Details

  • **Logged in (Y/N)?**N/A
  • Browser type/version? N/A
  • **Operating system?**N/A
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Apply enough scroll-padding to the top of the html element to offset the incorrect positioning. You will likely need to use different amounts for mobile and desktop.

mekarpeles avatar May 11 '22 20:05 mekarpeles

I'm interested in working on this issue. Is there an ideal position for the viewport?

jeremyng353 avatar May 13 '22 13:05 jeremyng353

@jeremyng353 thank you for your interest in this issue Lead @jimchamp will answer your question on this issue once you have all the necessary information for the issue, I will assign this issue to you Happy Contributing 🕺🏼 Have a good day ahead

tuminzee avatar May 14 '22 05:05 tuminzee

Hi @tuminzee , This issue seems to be a good initiation of my journey towards contribution to FOSS projects. I see that this issue is yet to be resolved and is not assigned,Can you please assign this to me?

theshashankpal avatar Sep 10 '22 07:09 theshashankpal

Thanks @theshashankpal, help would be appreciated!

More context is provided in the duplicate issue #6627

One proposal is: Apply enough scroll-padding to the top of the html element to offset the incorrect positioning. You will likely need to use different amounts for mobile and desktop.

mekarpeles avatar Sep 12 '22 19:09 mekarpeles

Hi @mekarpeles , I am starting working on this, i will look into the proposal you made and will try and get this resolved!

sidney888 avatar Sep 27 '22 00:09 sidney888

This is happening again.

jimchamp avatar Mar 08 '23 00:03 jimchamp

Hi, I'd be happy to help solve this issue.

nikhnp avatar Mar 23 '23 15:03 nikhnp

This appears to no longer be the case!

cdrini avatar Jun 27 '23 15:06 cdrini