openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Replace "Not In Library" button with "Check local libraries"

Open mekarpeles opened this issue 2 years ago • 16 comments

Related to #5831

Problem

Patrons get confused when they see a button that says "Not in library". It's a dead end. Instead, we should give them a default action of searching for an Open Library book within their local libraries using Worldcat or LibraryLink.

Describe the problem that you'd like solved

Replace Not in library button: openlibrary org_search_q=the+best+thing mode=everything

With Check local libraries: openlibrary org_search_q=the+best+thing mode=everything (3)

Proposal & Constraints

  • The style should use the cta-btn--shell class.

  • The button should link to the Worldcat link in https://github.com/internetarchive/openlibrary/blob/master/openlibrary/macros/WorldcatLink.html#L9

  • Button must have analytics / click-tracking (to compare before/after)

Additional context

Code: https://github.com/internetarchive/openlibrary/blob/master/openlibrary/macros/LoanStatus.html#L137-L140

Stakeholders

@jimchamp @cdrini @seabelis @JeffKaplan @bfalling

mekarpeles avatar May 09 '22 19:05 mekarpeles

For now, clicking btn will go to Worldcat, eventually we may wish to explore integrations which show library availability from within the context of Open Library and the other valuable info we're able to show on the book page.

mekarpeles avatar May 09 '22 19:05 mekarpeles

@mekarpeles I see that you have self-assigned this issue. Would like me to work on this one?

tuminzee avatar May 14 '22 05:05 tuminzee

This one is a bit tricky and I'm almost done :)

mekarpeles avatar May 16 '22 17:05 mekarpeles

Prototype: Create a modal similar to the share modal which has tabs & iframe for checking Library.Link & Worldcat availability.

mekarpeles avatar Jun 20 '22 20:06 mekarpeles

Hi @mekarpeles I want to contribute to this issue but you mentioned that you're working on it but there is no update since October. Is it okay for me to take on the issue?

I am a open source beginner so I don't know what the norm is.

ThisIsRahmat avatar Jan 09 '23 20:01 ThisIsRahmat

hello @ThisIsRahmat I will list down few resources which can help you understand the codebase and flow better Readme.md https://github.com/internetarchive/openlibrary/blob/master/CONTRIBUTING.md

I hope this helps.

tuminzee avatar Jan 11 '23 09:01 tuminzee

hey i want to work on this issue please assign me this issue

ayushdhiman-py avatar Feb 11 '23 05:02 ayushdhiman-py

Hi, I'll be taking on this issue. I'll make a PR within this week.

JaydenTeoh avatar Mar 06 '23 17:03 JaydenTeoh

@mekarpeles Here is my current implementation for the modal. Please ignore the styling for now as I would probably need the designer's input. But the functionality is there already, will make an initial PR first and continue working on it once the design is settled. image

JaydenTeoh avatar Mar 11 '23 19:03 JaydenTeoh

This button is confusing both the old and the new ways. Should be clearer. Like, "This book is currently checked out by another reader. Would you like to be notified once it is returned? Also, you can [ CHECK LOCAL LIBRARIES ]" (wording can be different, but this is the idea).

weshatheleopard avatar Mar 30 '23 01:03 weshatheleopard

Yeah I am very happy to work with thus good first issue. Will you assign to me please

prasoon2510 avatar Aug 22 '23 00:08 prasoon2510

Howdy folks, there's an open PR for this one, and this needs a bit more planning for direction :) Removing the good first issue label for now.

If you're looking for other places to help out, check out this list: internetarchive/openlibrary/issues (is:open label:"Needs: Help" label:"Good First Issue")

cdrini avatar Aug 28 '23 19:08 cdrini