openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Switch TWA from pointing to testing.openlibrary.org to openlibrary.org

Open cdrini opened this issue 3 years ago • 4 comments

Note this is causing edits from the app to behave strangely / not show up (as is the case on testing.openlibrary.org)

Stakeholders

@bicolino34

cdrini avatar Apr 04 '22 20:04 cdrini

TWA now points to openlibrary.org

bicolino34 avatar Sep 05 '22 12:09 bicolino34

@cdrini @bicolino34 It would be great if we can generate a new APK and update it on Google Play Store because currently, it's using the testing.openlibrary.org APK

I think we need to create a new APK with openlibrary URL and also change the SHA to the one provided by Play Store.

From Stackoverflow: https://stackoverflow.com/questions/54597728/trusted-web-activity-address-bar-not-hide-chrome-for-android-72

You may have opted into having Google Play sign your releases with a key they generated and only use your key for the upload. If you did, go to Google Play Console Release Management -> App Signing and copy the App signing certificate SHA-256 fingerprint and put it into the assetlinks.json file.

SaravgiYash avatar Sep 09 '22 06:09 SaravgiYash

Indeed. It is still pointing to testing.openlibrary.org. my mistake. Sorry for that

bicolino34 avatar Sep 09 '22 07:09 bicolino34

Generating a new APK and updating the SHA-256 (from Play Store) here should fix the issue

APK Creation Process:

Using Bubblewrap: https://github.com/GoogleChromeLabs/bubblewrap https://github.com/GoogleChromeLabs/bubblewrap/tree/main/packages/cli To create: bubblewrap init --manifest https://my-twa.com/manifest.json To generate assetlinks.json: bubblewrap fingerprint add <sha-256 fingerprint from Play Store>

SaravgiYash avatar Sep 09 '22 07:09 SaravgiYash

Theoretically done. Keys registered with olsystem https://github.com/internetarchive/olsystem/commit/4570982924249ae2f91bfa80a54492cc2e35e9fe image

mekarpeles avatar Oct 02 '23 21:10 mekarpeles

@mekarpeles not theoretical anymore. Update just rolled out to me :) image

RayBB avatar Oct 15 '23 14:10 RayBB