openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Fix /config/edition

Open LeadSongDog opened this issue 3 years ago • 4 comments

@mekarpeles The /config/edition page has long been a mess. Previous issues internetarchive/openlibrary#142 internetarchive/openlibrary#725 seem to have been inadvertently closed without a fix. Regular users seem to lack permission to edit the file and no indication is shown of how to get it corrected. User "Administrator" has made a ton of edits with each appending one blank line. Many of the URL formats shown no longer work, or redirect. Many more identifiers simply don’t show a corresponding URL.

Without working hot links for external identifiers, they will rarely be useful. With them, many rich libraries’ catalogues (and often content) become more accessible.

  • [x] internetarchive/openlibrary#7826
  • [x] internetarchive/openlibrary#7825
  • [x] internetarchive/openlibrary#7824
  • [x] internetarchive/openlibrary#8294
  • [x] internetarchive/openlibrary#7785

LeadSongDog avatar Mar 31 '22 13:03 LeadSongDog

CC @onnotasler who has been creating lots of great specific issues about what needs to be fixed. I think that's what we need to make progress on this ; basically a list of fixes.

@LeadSongDog could you create an issue for the blank line thing? Any other specific issues on that page that need to be fixed?

cdrini avatar May 01 '23 19:05 cdrini

Indeed, I created several bugs with broken identifiers. I have not checked all identifiers yet, though.

internetarchive/openlibrary#7826 internetarchive/openlibrary#7825 internetarchive/openlibrary#7824 internetarchive/openlibrary#8294 internetarchive/openlibrary#7785

onnotasler avatar May 01 '23 19:05 onnotasler

Thank you @onnotasler ! I'm going to assign this one to you and promote those issues to a checklist here :)

cdrini avatar May 01 '23 19:05 cdrini

Assignees removed automatically after 14 days.

github-actions[bot] avatar Jan 25 '24 08:01 github-actions[bot]

Edition identifiers are now defined in a version-controlled file, so issues requesting new identifiers should no longer be accidentally closed.

The extra line being added on config edit likely still remains, but is tracked by #7840.

Can this be closed?

jimchamp avatar Apr 17 '25 23:04 jimchamp