openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Published 20 hours ago • verified publisher icon internetarchive

Disable Authorname for work parameter

Open shucon opened this issue 4 years ago • 6 comments

Fixes: https://github.com/internetarchive/openlibrary/issues/3523

[FIX]

Screenshot

Screenshot from 2020-06-29 00-07-58

Stakeholders

@tabshaikh

shucon avatar Jun 28 '20 18:06 shucon

@mekarpeles

shucon avatar Jul 01 '20 17:07 shucon

The code lgtm, what is the best way to test this fix? Thank you @shucon

mekarpeles avatar Jul 06 '20 05:07 mekarpeles

Maybe testing whether it works perfectly while adding a new book and while just adding a new edition.

shucon avatar Jul 06 '20 07:07 shucon

I think the two PRs should be kept separate.

shucon avatar Jul 06 '20 18:07 shucon

Okay, that seems reasonable to get it in 2 separate pr's. @shucon would love your help in opening a second pr for enabling edition titles to be edited and then will merge both the pr's together and close the issue. Holding this pr for next week as this week we have a huge sea of changes coming to production :smile:

tabshaikh avatar Jul 07 '20 06:07 tabshaikh

I think this may need to be rebased -- @tabshaikh has been busy on other projects, we're re-assigning it to me for the time being.

mekarpeles avatar Aug 08 '22 19:08 mekarpeles

I think we're so far behind on this one in terms of rebasing etc that it makes most sense to close for now. Apologies.

mekarpeles avatar Dec 12 '22 20:12 mekarpeles