openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Search inside feature seems to be broken in recent release

Open agmckee opened this issue 1 month ago • 2 comments

Problem

Search inside seems to be broken, the search succeeds but the search results are not shown. Checked in two browsers, namely Firefox and Chromium.

https://openlibrary.org/search/inside

Image

Initially I thought it was accented characters and almost raised a bug report for that but then while checking checking normal ASCII-range characters I still had the same issue.

Reproducing the bug

Go to search inside page. Search for any string whatsoever. Observe number of results shown is non-negative but search results aren't actually displayed.

  • Expected behavior: Search results should be displayed as was previously the case.
  • Actual behavior: "About 3,481 results found in 1.92 seconds" but no search results are actually displayed.

Context

  • Browser (Chrome, Safari, Firefox, etc): Firefox and Chromium
  • OS (Windows, Mac, etc): Linux
  • Logged in (Y/N): Tried logged in and logged out, same results.
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

agmckee avatar Nov 27 '25 15:11 agmckee

I thought this might be a transient problem of some kind so I waited a couple of hours before raising this issue.

agmckee avatar Nov 27 '25 15:11 agmckee

Thank you for the report ; this appears to be caused by #11520

cdrini avatar Nov 27 '25 16:11 cdrini

I see this somehow referenced by #11519? Can this be closed? Either way, https://openlibrary.org/search/inside?q=abbe+de+beaumont+poire&has_fulltext=true seems to work so moving down to P3

mekarpeles avatar Dec 15 '25 21:12 mekarpeles

I am happy for this to be closed. I think @cdrini fixed it with a hotfix but maybe #11521 needs reviewing and merging for the more permanent resolution. Maybe Drini can confirm.

I'd like to thank you both for your attention to this issue and particularly @cdrini for the quick fix, however it was done. I was able to continue with my research as a result of this issue being addressed quickly, and I am very grateful.

agmckee avatar Dec 15 '25 21:12 agmckee