openlibrary
openlibrary copied to clipboard
internetarchive
Edition table filter doesn't correctly do diacritic folding
Problem
As stated in title
Search "germenes"
Search "gérmenes"
Reproducing the bug
- Go to https://openlibrary.org/works/OL276558W
- Click "Afficher les 58 éditions"
- Type "armas" in the Search field
- Note the 15 editions and their titles
- Replace "armas" with "germenes" and note how the the list changes to just 6 editions
- Replace "germenes" with "gérmenes" and note that the list now consists of 8 different editions
- Expected behavior: Both search terms match the same set of 14 diacritic folded titles
- Actual behavior: Titles have to match exactly (probably including Unicode normalizatin form, I suspect)
Context
- Browser (Chrome, Safari, Firefox, etc): Chrome
- OS (Windows, Mac, etc): Mac
- Logged in (Y/N): Y
- Environment (prod, dev, local): prod
Breakdown
Requirements Checklist
- [ ]
Related files
Stakeholders
Instructions for Contributors
- Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
Is there a Data Tables feature to support this?
If that question is directed at me, I'd guess there is, but the implementing engineer will need to investigate.
This is the datatables library we use for whoever has some time to investigate: https://datatables.net/ . Not we have version 1.13 which is rather old now, we might need to update it to get any new features we need.
