bookreader icon indicating copy to clipboard operation
bookreader copied to clipboard

Return $el when enableSearch is false

Open pcambra opened this issue 4 years ago • 1 comments

If enableSearch is false, buildMobileDrawerElement doesn't return the element so it is very complicated to alter, I think it should return $el so it can be extended.

This is a PR with the change I want to make, I think I need to compile the libraries as well

pcambra avatar Jan 26 '21 11:01 pcambra

Codecov Report

Merging #613 (859487d) into master (e2a6a32) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   65.78%   65.78%           
=======================================
  Files          35       35           
  Lines        3761     3761           
  Branches      708      708           
=======================================
  Hits         2474     2474           
  Misses       1035     1035           
  Partials      252      252           
Impacted Files Coverage Δ
src/js/plugins/search/plugin.search.js 56.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2a6a32...859487d. Read the comment docs.

codecov[bot] avatar Jan 26 '21 11:01 codecov[bot]