bookreader
bookreader copied to clipboard
Move event name into events.js #460
Done the following changes:
- Update events 'list' to include new field: pageChanged = 'pageChanged';
- find all the places pageChanged is used, and point it to its new reference (events.pageChanged)
- Make sure that the event BookReader:pageChanged is emitted when changing the page
- Make sure all tests pass
Codecov Report
Merging #559 (0a5f4e6) into master (639833a) will increase coverage by
6.46%
. The diff coverage isn/a
.
:exclamation: Current head 0a5f4e6 differs from pull request most recent head ac4c829. Consider uploading reports for the commit ac4c829 to get more accurate results
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 66.64% 73.11% +6.46%
==========================================
Files 36 14 -22
Lines 3904 558 -3346
Branches 747 129 -618
==========================================
- Hits 2602 408 -2194
+ Misses 1040 117 -923
+ Partials 262 33 -229
Impacted Files | Coverage Δ | |
---|---|---|
src/js/BookReader/utils.js | 52.63% <0.00%> (-31.99%) |
:arrow_down: |
src/js/BookReader/BookModel.js | 81.60% <0.00%> (-6.41%) |
:arrow_down: |
src/js/plugins/search/plugin.search.js | ||
src/js/BookReader/Toolbar/Toolbar.js | ||
src/js/plugins/plugin.print.js | ||
src/js/plugins/plugin.archive_analytics.js | ||
src/js/plugins/search/view.js | ||
src/js/plugins/plugin.url.js | ||
src/js/BookReader/ImageCache.js | ||
src/js/plugins/plugin.autoplay.js | ||
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 639833a...ac4c829. Read the comment docs.
please update issue with fix request in comment.
Also, please use format that the other
trigger
use in passing in value.
I've mentioned the pull request link in the comment of the issue. Also, I've changed the format for passing the value to as used in other places in the same file.