bookreader
bookreader copied to clipboard
Replace deprecated $.bind with $.on
Not really a blocker or anything, but nice to have in case we ever try to update from jquery 1 :/
Codecov Report
Merging #519 into master will decrease coverage by
1.71%. The diff coverage is71.42%.
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
- Coverage 62.62% 60.90% -1.72%
==========================================
Files 36 36
Lines 3743 3745 +2
Branches 713 713
==========================================
- Hits 2344 2281 -63
- Misses 1129 1183 +54
- Partials 270 281 +11
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/js/BookReader/utils.js | 84.21% <0.00%> (ø) |
|
| src/js/plugins/plugin.archive_analytics.js | 28.12% <0.00%> (ø) |
|
| src/js/plugins/plugin.chapters.js | 32.22% <0.00%> (-45.56%) |
:arrow_down: |
| src/js/plugins/plugin.vendor-fullscreen.js | 56.81% <0.00%> (ø) |
|
| src/js/BookReader.js | 67.59% <80.00%> (+0.04%) |
:arrow_up: |
| src/js/BookReader/Mode2Up.js | 49.42% <100.00%> (ø) |
|
| src/js/BookReader/Navbar/Navbar.js | 89.28% <100.00%> (ø) |
|
| src/js/plugins/plugin.autoplay.js | 72.22% <100.00%> (ø) |
|
| src/js/plugins/plugin.iframe.js | 64.28% <100.00%> (ø) |
|
| src/js/plugins/plugin.mobile_nav.js | 43.52% <100.00%> (-25.89%) |
:arrow_down: |
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1b59d00...000a390. Read the comment docs.