bookreader icon indicating copy to clipboard operation
bookreader copied to clipboard

TMP: Add Ink plugin!

Open cdrini opened this issue 5 years ago • 1 comments

Results of hackathon over the weekend, if folks want to see the code :)

Nowhere anywhere near prod-ready :) Still very much demo/proof-of-concept.

Try it here: https://www-drini.archive.org/details/goody

Stuff that works:

  • [x] Drawing with a pen
  • [x] Drawings persist between page flips
  • [x] Drawings persist between SOME mode changes
  • [x] The drawings scale for different zoom levels
  • [x] Stroke erasing with pen eraser button

Known issues:

  • [x] Need to hover over page to get the page to become drawable/update scaling
  • [ ] Switching to mode2up, drawings disappear for some reason
  • [ ] FF is garbage at pen input
  • [x] Touch/mouse also make pen markings
  • [ ] NOTHING PERSISTS ANYWHERE!

cdrini avatar Jun 01 '20 19:06 cdrini

Codecov Report

Merging #330 (415cf0f) into master (7b6aa5b) will increase coverage by 0.29%. The diff coverage is 28.57%.

:exclamation: Current head 415cf0f differs from pull request most recent head 8f2bd47. Consider uploading reports for the commit 8f2bd47 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   65.99%   66.28%   +0.29%     
==========================================
  Files          60       60              
  Lines        5049     5048       -1     
  Branches      815      814       -1     
==========================================
+ Hits         3332     3346      +14     
+ Misses       1704     1690      -14     
+ Partials       13       12       -1     
Impacted Files Coverage Δ
.../visual-adjustments/visual-adjustments-provider.js 51.51% <0.00%> (ø)
src/BookReader/Mode1Up.js 54.28% <0.00%> (-13.58%) :arrow_down:
src/BookReader/options.js 100.00% <ø> (ø)
src/BookReader.js 63.71% <25.00%> (+0.64%) :arrow_up:
src/BookReader/ModeThumb.js 69.71% <71.42%> (+6.70%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b6aa5b...8f2bd47. Read the comment docs.

codecov[bot] avatar Jun 04 '20 15:06 codecov[bot]