bookreader icon indicating copy to clipboard operation
bookreader copied to clipboard

Typo in a constructor property

Open manish0kuniyal opened this issue 1 year ago • 2 comments

Description

In the file search-results.js which is inside src/BookNavigator/search/search-results.js there is a typo. In the IABookSearchResults class, there is a property named renderSearchAllFields in the constructor, but the correct property name is renderSearchAllFiles according to the static properties definition.

Evidence / Screenshot (if possible) image

Expectation

Instead of:

this.renderSearchAllFields = false;

It should be:

this.renderSearchAllFiles = false;

manish0kuniyal avatar Dec 30 '23 19:12 manish0kuniyal

hey, i have fixed this typo can i make a pr now

sahalbelam avatar Aug 19 '24 06:08 sahalbelam

I think so this issue is already resolved

Ankush1oo8 avatar Mar 09 '25 17:03 Ankush1oo8