ilp-plugin-ethereum icon indicating copy to clipboard operation
ilp-plugin-ethereum copied to clipboard

Add unit tests

Open dino-rodriguez opened this issue 6 years ago • 2 comments

What happened to the unit tests? I noticed the branch is gone.

A lot of those tests were testing balance/account/store logic as well as packet construction very thoroughly. If they are gone, it is very possible that somebody could edit the plugin and cause a minor breaking change (like balance logic not being calculated properly or persisted to the store) and the integration tests would still pass. I feel this could be pretty dangerous considering the plugin is in beta and will have updates.

dino-rodriguez avatar Sep 21 '18 21:09 dino-rodriguez

The branch had been merged in, so they're all in the commit history for ko-refactor. I do still intend to adapt those unit tests for the updated plugin, but probably not before release.

kincaidoneil avatar Sep 21 '18 21:09 kincaidoneil

Ok great, that makes sense.

dino-rodriguez avatar Sep 21 '18 21:09 dino-rodriguez