ilp-connector icon indicating copy to clipboard operation
ilp-connector copied to clipboard

refactor: minor cleanup

Open justmoon opened this issue 7 years ago • 2 comments

Some assorted minor cleanup things. (Did a tour of the codebase for someone and noticed these issues.)

justmoon avatar Oct 17 '18 04:10 justmoon

Codecov Report

Merging #463 into master will increase coverage by 0.01%. The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #463      +/-   ##
=========================================
+ Coverage   71.68%   71.7%   +0.01%     
=========================================
  Files          44      44              
  Lines        2038    2032       -6     
  Branches      327     327              
=========================================
- Hits         1461    1457       -4     
+ Misses        577     575       -2
Impacted Files Coverage Δ
src/services/core.ts 72% <ø> (-3.87%) :arrow_down:
src/app.ts 55.26% <0%> (+1.41%) :arrow_up:
src/services/route-builder.ts 90.38% <66.66%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e00e24d...d210fba. Read the comment docs.

codecov-io avatar Oct 17 '18 04:10 codecov-io

Codecov Report

Merging #463 into master will increase coverage by 0.01%. The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   71.68%   71.70%   +0.01%     
==========================================
  Files          44       44              
  Lines        2038     2032       -6     
  Branches      327      327              
==========================================
- Hits         1461     1457       -4     
+ Misses        577      575       -2     
Impacted Files Coverage Δ
src/app.ts 55.26% <0.00%> (+1.41%) :arrow_up:
src/services/core.ts 72.00% <ø> (-3.87%) :arrow_down:
src/services/route-builder.ts 90.38% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e00e24d...d210fba. Read the comment docs.

codecov-commenter avatar Jun 15 '20 17:06 codecov-commenter