five-bells-condition

five-bells-condition copied to clipboard

See https://github.com/interledgerjs/five-bells-condition/blob/master/src/lib/condition.js#L266 ``` /** * Set the maximum fulfillment length. * * The maximum fulfillment length is normally calculated automatically, when * calling `Fulfillment#getCondition`. However, when * * @param {Number}...

intelliot

Throwing errors may be useful if one is targeting to build end-user applications, but for developing middleware it would be very cumbersome to juggle the flow around the exceptions. It...

KrishnaPG

Readme has confusing example usage of validateFulfillment

1

The following snippet found in a few places in the readme makes it look like `validateFulfillment` returns a boolean to indicate validation whereas it actually throws an error for invalid...

clark800

See https://github.com/interledgerjs/five-bells-condition/blob/master/src/types/threshold-sha256.js#L246 for instance.

sbellem

The two functions are identical: ```js /** * Base class for fulfillment types. */ class Fulfillment { serializeUri () { return base64url.encode(this.serializeBinary()) } serializeBase64Url () { return base64url.encode(this.serializeBinary()) } ```...

sbellem

The code for validating a condition is : ```js validate () { // Get info for type ID, throws on error TypeRegistry.findByTypeId(this.getTypeId()) // Bitmask can have at most 32 bits...

sbellem

I did the best part of an implementation of Crypto-Conditions in Haskell ([link](https://github.com/libscott/cryptoconditions-hs)) (I work for BigchainDB), and when I came to test my code against the provided [test suite](https://github.com/interledgerjs/five-bells-condition/tree/master/testsuite/valid)...

ssadler

[RFC 4648 states](https://tools.ietf.org/html/rfc4648#section-5): ``` The pad character "=" is typically percent-encoded when used in an URI [9], but if the data length is known implicitly, this can be avoided by...

stevenroose

The Crypto-Conditions spec does not mention anything about the used OER encoding to be either Basic OER or Canonical OER. So these tests should be left out or the reference...

stevenroose

Throw a more descriptive error if no message is provided when validating an ed25519 condition/fulfillment

1

Found by @inacali in https://github.com/interledger/five-bells-condition/issues/51 If you run the following and leave out the message from the second to last line you'll see a `ValidationError: Invalid ed25519 signature` error. It...

emschwartz