web-monetization-projects icon indicating copy to clipboard operation
web-monetization-projects copied to clipboard

[Firefox] Popup gets in confused state when use menu

Open sublimator opened this issue 3 years ago • 3 comments

image image

  1. Go to a monetized site
  2. Open the popup
  3. Click on "about" menu item which will navigate to https://coil.com/about

The popup is still showing as if it's still on the monetized page

sublimator avatar Jun 27 '21 06:06 sublimator

Checked and this definitely does NOT happen on Chrome

sublimator avatar Jun 28 '21 03:06 sublimator

Not sure why this is happening. It could potentially be a bug in FF itself but couldn't see any symptoms of that in the logging (missed events or something)

Potentially could change the menu item handlers to send a message to the background page, which as well as opening the tab, would send a closePopup message to the popup. This could be selectively ignored on Safari.

Or we could just create a function closePopup () {...} that contains the special case Safari handling logic (perhaps #1077 fixed in Safari 15 ??)

sublimator avatar Jun 28 '21 10:06 sublimator

perhaps #1077 fixed in Safari 15 ??

This is fixed in Safari 15

sublimator avatar Jul 16 '21 04:07 sublimator