web-monetization-projects icon indicating copy to clipboard operation
web-monetization-projects copied to clipboard

Yarn v2

Open sublimator opened this issue 4 years ago • 0 comments

  • [x] migrate to yarn v2, in #1045

Followups:

  • [x] dependabot issues
    • it generates v1 yarn.lock files
    • workaround currently is to manually pull the dependency, run yarn, amend the commit
    • function update_wm_dependabot_branch() {
          cd `git rev-parse --show-toplevel`
          git fetch origin
          git checkout $1
          git checkout HEAD^ -- yarn.lock
          yarn
          yarn dedupe
          git add `git rev-parse --show-toplevel` && gc --amend --no-edit --reset-author --no-verify
          git push -f
      }
      
    • people have created Github Actions to automate this process
      • https://github.com/dependabot/dependabot-core/issues/1297#issuecomment-671131912
  • [ ] sjcl
    • currently using a fork, with the built sjcl.js committed to the repository (previous was 3 years old)
  • [ ] over-specified devDependencies
    • currently using the yarn upkeep command to push all devDependencies from the root to the workspace package.jsons
      • slightly annoying to have so many packages obfuscating the list of unique dependencies in a workspace
        • Could be improved by keeping a list of the obvious root only packages
        • Could automate something in packageExtensions, but that would probably require some kind of yarn plugin so it would integrate nicely with CI and cli usage of yarn.
  • [x] @types/chrome completions don't seem to be working in IntelliJ
    • image
    • workaround seems to be to specify arg = chrome form to imply the chrome type, rather than arg: typeof chrome, e.g. constructor(a: number, b: string, @inject(tokens.WextApi) api = chrome)

sublimator avatar Sep 09 '20 05:09 sublimator