web-monetization-extension icon indicating copy to clipboard operation
web-monetization-extension copied to clipboard

Published 20 hours ago • verified publisher icon interledger

Simplify ConnectWalletForm

Open sidvishnoi opened this issue 9 months ago • 1 comments

The form has become too complicated for a simple form with two fields. As mentioned in https://github.com/interledger/web-monetization-extension/pull/940. Architect it a bit better, so new things are easier to add. Also, reduce re-renders happening too often (we've more props than state). React upgrade to v19 might help with simplification too.

Suggestions:

  • Split components
  • Use uncontrolled components, and use FormData to get latest state

This will make https://github.com/interledger/web-monetization-extension/issues/977 easier to support too.

Some re-renders also trigger random very less visible non-fatal errors too.

sidvishnoi avatar Mar 04 '25 14:03 sidvishnoi

Prioritizing this as it blocks fixing E2E tests, as they broke in https://github.com/interledger/web-monetization-extension/pull/1073. Doing this via https://github.com/interledger/web-monetization-extension/issues/1121.

sidvishnoi avatar Jul 09 '25 11:07 sidvishnoi