web-monetization-extension icon indicating copy to clipboard operation
web-monetization-extension copied to clipboard

Display WM icon differently if website is/isn't monetized

Open raducristianpopa opened this issue 1 year ago • 5 comments

Context

When a user has the WM extension installed, and they have successfully connected their wallet address to the extension, then the icon of the extension must look different depending on whether the user is currently visiting a web monetized website or not.

When a user is visiting a site:

  • If the site has no monetization tag with a valid wallet address url:

  • If the site has at least one monetization tag with a valid wallet address url:

  • If extension has web monetization globally disabled:

raducristianpopa avatar Jan 16 '24 09:01 raducristianpopa

Please update the context for us @ionutanin

tselit avatar Feb 15 '24 14:02 tselit

as @raducristianpopa suggested: we should update the background message handler to use switch case rather than use separate files for each message

ionutanin avatar Feb 27 '24 17:02 ionutanin

We decided to repurpose this ticket, so please disregard any of the comments prior to 10 Apr 2024

tselit avatar Apr 10 '24 15:04 tselit

Should be ready for peer review on Wed, 17 Apr. Aiming to merge by the end of this week, 19 Apr.

tselit avatar Apr 16 '24 14:04 tselit

Review feedback shared today. Aiming to resolve and have ready for final merging on Thurs, 2 May.

tselit avatar Apr 30 '24 15:04 tselit

Issue 1 - PR feedback from Max:

  • when WM is globally disabled
  • then navigate to a WMized website
  • then enable WM globally
  • expected behaviour: the WM icon should be updated to show that the site is monetized but currently the WM ext icon appears as though the site is NOT WMized

tselit avatar May 07 '24 14:05 tselit

Secondary issue found:

  • the state the that the icon was in on the previously opened tab remains (or is carried over) when a new (blank) tab is opened (this can be confusing as it may appear as WM is active or disabled, or whatever the previously opened site's WM status was).
  • still under discussion

tselit avatar May 07 '24 14:05 tselit

Related to Issue 1 above: the WM event is not triggered when re-enabling WM globally. This will be addressed as part of this ticket.

tselit avatar May 09 '24 09:05 tselit