web-monetization-extension icon indicating copy to clipboard operation
web-monetization-extension copied to clipboard

WM ext browser support - Edge

Open tselit opened this issue 1 year ago • 2 comments

Context

WM extension compatibility with the Microsoft Edge browser.

Todos

TBC

tselit avatar Dec 20 '23 12:12 tselit

Bibi to do: test on Edge and then should be ready to close

tselit avatar Jun 19 '24 11:06 tselit

To test: How it works in split-window mode (https://github.com/interledger/web-monetization-extension/pull/366#discussion_r1673836423)

sidvishnoi avatar Jul 15 '24 08:07 sidvishnoi

In split view, the extension is only taking into the consideration only the first pane from the split view when updating icon. If we are on a non-monetized website in the first pane and on a web monetized one in the second one, the icon will have the non-monetized website identifier.

image

raducristianpopa avatar Aug 21 '24 13:08 raducristianpopa

Arc's split view should be checked as well. Vivaldi's tab tiling as well.

raducristianpopa avatar Aug 21 '24 13:08 raducristianpopa

Blocked as we wait for the MS support team

RabebOthmani avatar Aug 28 '24 08:08 RabebOthmani

https://github.com/microsoft/MicrosoftEdge-Extensions/discussions/102 🤷🏽‍♂️🤦🏽 https://github.com/uBlockOrigin/uBlock-issues/issues/2945

sidvishnoi avatar Sep 12 '24 11:09 sidvishnoi

Found the sender port in Runtime.Port message handler returns correct tab ID 🎉

port.onMessage.addListener((message, sendingPort) => {
   console.log(sendingPort.sender?.tab?.id);
});

So, we can make a short connection on content script inject and store tabId for use in future messages?

Edit: or instead of tabActivated event, rely on focusChange messages from content script.

sidvishnoi avatar Sep 12 '24 12:09 sidvishnoi

Everything works once we get right tabId, except Edge doesn't update the icon (even with correct tabId!)

sidvishnoi avatar Sep 17 '24 12:09 sidvishnoi