testnet icon indicating copy to clipboard operation
testnet copied to clipboard

feat: WM on Test wallet

Open sanducb opened this issue 8 months ago • 7 comments

Context

  • closes #1358
  • closes #1357

This PR introduces changes that will allow creation of asset scale 9 wallet addresses by default and all WM accounting logic is removed as there will be no difference between payment pointers. Rapyd will only take into account asset scale 2 (this is unchanged) while we also keep track of an asset scale 9 "virtual" balance in our wallet's db. This virtual balance is separated into incomingBalance and outgoingBalance for each PP. Whenever scale 9 incoming or outgoing transfers add up to the lowest amount representable in scale 2 (i.e. 0.01), then Rapyd balance is updated. This is similar to the previous WM accounting logic, but it now applies to all transactions.

Changes TLDR;

  • Allowing creation of asset scale 9 wallet addresses by default
  • Deleted WM accounting logic, wallet addresses are WM ready by default
  • Added virtual balance logic for dealing with scale 9 amounts

Important questions

  • Should we drop incomingBalance and outgoingBalance columns from walletAddresses table and move them to accounts table?
  • Should we drop debt column in the accounts table?

sanducb avatar Jun 27 '24 08:06 sanducb