rafiki icon indicating copy to clipboard operation
rafiki copied to clipboard

Published 20 hours ago • verified publisher icon interledger

refactor(backend): update config variables

Open omertoast opened this issue 2 years ago • 1 comments

Changes proposed in this pull request

  • Clear config variable names
  • Fewer environment variables in configs

Context

In my previous pull request, @wilsonianb suggested that we can make config variables simpler by removing port variables and combining them into URLs.

Checklist

  • [x] Related issues linked using fixes #number
  • [x] Tests added/updated
  • [x] Documentation added
  • [ ] Make sure that all checks pass

omertoast avatar Aug 23 '22 10:08 omertoast

@omertoast Please also update the logs here to say where each server is listening.

DonChangfoot avatar Aug 24 '22 08:08 DonChangfoot

What's the status of this? I got tripped by the current config fields: https://github.com/interledger/rafiki/pull/595/commits/8928c14ea6f7e56e87b47b3a106e9c77d95bbd96 Let me know if you want help resolving conflicts.

wilsonianb avatar Sep 14 '22 02:09 wilsonianb

I think there are a lot of things changed since I created this PR and it feels like it's just dangling right now. I'm going to close this and we can re-open it in the future if we need it.

omertoast avatar Oct 20 '22 08:10 omertoast