rafiki icon indicating copy to clipboard operation
rafiki copied to clipboard
verified publisher icon interledger

feat(walletAddressKeys): list wallet address keys

Open golobitch opened this issue 1 year ago • 1 comments

Changes proposed in this pull request

  • Add API for fetching wallet address keys

Context

fixes #2631

Checklist

  • [x] Related issues linked using fixes #number
  • [ ] Tests added/updated
  • [ ] Documentation added
  • [x] Make sure that all checks pass
  • [ ] Bruno collection updated

golobitch avatar Apr 05 '24 22:04 golobitch

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
Latest commit 8e1bf5d4d9c33373db8b5e4f32a7d08ac188032c
Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6621790b336ec400086a120b

netlify[bot] avatar Apr 05 '24 22:04 netlify[bot]

Looks good 👍 . Last thing, we should add a Bruno query for Get Wallet Address Keys

@mkurapov I added Bruno query for Get Wallet Address Key instead of a plural form, just to be consistent with other examples. There is also field resolver for incoming and outgoing payments.

golobitch avatar Apr 16 '24 19:04 golobitch

@mkurapov I added Bruno query for Get Wallet Address Key instead of a plural form, just to be consistent with other examples. There is also field resolver for incoming and outgoing payments.

We do have "Get Peers" and "Get Payments" so I think the plural would actually be consistent since this uses pagination?

sabineschaller avatar Apr 17 '24 08:04 sabineschaller

@mkurapov I have added new Bruno query for fetching wallet addresses keys. We can do another iteration of this PR.

golobitch avatar Apr 18 '24 17:04 golobitch