rafiki icon indicating copy to clipboard operation
rafiki copied to clipboard
verified publisher icon interledger

fix: add node_env env var to frontend

Open BlairCurrey opened this issue 1 year ago • 2 comments

Changes proposed in this pull request

  • adds production nodeEnv to frontend

Context

fixes https://github.com/interledger/rafiki/issues/2592

Depends on ~~https://github.com/interledger/helm-charts/pull/27~~ https://github.com/interledger/helm-charts/pull/35 Will need to merge that first.

Checklist

  • [ ] Related issues linked using fixes #number
  • [ ] Tests added/updated
  • [ ] Documentation added
  • [ ] Make sure that all checks pass
  • [ ] Bruno collection updated

BlairCurrey avatar Mar 25 '24 17:03 BlairCurrey

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
Latest commit d2d562eb8ad0095f65d62b14126692fefc7e254a
Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/663a429e861c160008b71a05

netlify[bot] avatar Mar 25 '24 17:03 netlify[bot]

@BlairCurrey I also opened up PR in helm-charts repo to add nodeEnv variable in helm charts (exactly the same way as it is for backend and auth) so that we can specify this in values.yaml file when deploying helm.

https://github.com/interledger/helm-charts/pull/27

golobitch avatar Mar 27 '24 23:03 golobitch

To be perfectly honest, this is not needed, since default value is set to production in helm-charts repository. I suppose that we can just close this PR?

golobitch avatar May 10 '24 10:05 golobitch