rafiki icon indicating copy to clipboard operation
rafiki copied to clipboard

Include handler for `payment_pointer.web_monetization` webhook event in Mock ASE

Open sabineschaller opened this issue 1 year ago • 4 comments

Context

The Mock ASE currently does not handle payment_pointer.web_monetization webhook events. Since it should also serve as a reference for actual integrators, all webhook events should be handled.

Note: As of the creation of this issue, it is still called payment_pointer. However, we are in the process of changing this to wallet_address.

Todos

  • [x] include handler here
  • [x] handle event case here

sabineschaller avatar Oct 19 '23 09:10 sabineschaller

Hello @sabineschaller! I would like to work on this issue. Could you please assign me?

manulpatel avatar Oct 19 '23 09:10 manulpatel

Hi @manulpatel , it's yours 🙂

sabineschaller avatar Oct 19 '23 13:10 sabineschaller

Hey team, @sabineschaller @manulpatel, Can I take this one, if this issue is still open?

Shubham2503 avatar Oct 24 '23 14:10 Shubham2503

Currently the docs indicate calling the WithdrawEventLiquidity endpoint in this webhook handler. However, this handler is being deprecated and we should be able to use createWalletAddressWithdrawal instead.

Also, this webhook never actually fires. We might be able to manually test by:

  • changing walletAddressService.create to do something like this: https://github.com/interledger/rafiki/commit/70a03ad05bb2798f42b2b24cde654848db348b6c
  • create a new wallet address via postman
  • call triggerWalletAddressEvents via postman which should trigger handleWalletAddressWebMonetization

BlairCurrey avatar Nov 27 '23 19:11 BlairCurrey