interledger-rs icon indicating copy to clipboard operation
interledger-rs copied to clipboard

Tracking breaking changes

Open koivunej opened this issue 4 years ago • 2 comments

While handling the latest 1.49 clippy lints in #667, there are at least two public instances of Result<_, ()> which are now nagged by clippy changing of which require a minor version bump:

  • 2233dc97c614a212f75ddb417b46f937aa589477 (interledger-settlement)
  • 170c9e7062df6fff157fac11d09277e5ec621192 (interledger-stream)
  • 43728cfbafa9b89ef1978faf1a2511c1cf881833 (interledger-store)
  • whole of #690 which updated bytes = "0.4" of interledger-packet which is re-exported
  • #719 changed interledger-packet::ErrorCode::new signature

Given commit 3f1a8de2a359c02c8d8edda88eacdd652d3992bd I had thought that 1.0.0 versions had already been pushed, but in light of us needing to make breaking changes to keep up with clippy, I'd recommend reverting the 1.0.0 bump and going ahead with the next released versions being 0.x series. crates.io doesn't have any 1.0 crates nor does dockerhub, at least as far as I can search it.

koivunej avatar Jan 15 '21 10:01 koivunej

As I already commented on the 667, we need a way to start marking the commits with breaking changes. I suggest conventional commits with ! in the scope and BREAKING CHANGE in the "footer". Also, we need to go back in time to find other breaking changes.

koivunej avatar Jan 15 '21 10:01 koivunej

I'd recommend reverting the 1.0.0 bump and going ahead with the next released versions being 0.x series. crates.io doesn't have any 1.0 crates nor does dockerhub, at least as far as I can search it.

Sounds good to me 👍 (personally... wasn't a big fan of that "1.0" release)

kincaidoneil avatar Jan 16 '21 04:01 kincaidoneil