five-bells-ledger icon indicating copy to clipboard operation
five-bells-ledger copied to clipboard

Should not be able to set balance manually

Open sharafian opened this issue 9 years ago • 2 comments

Brought up in https://github.com/interledgerjs/ilp-kit/issues/82#issuecomment-262402999 . Allowing PUT /accounts/:name to set the balance opens up potential errors.

sharafian avatar Nov 23 '16 00:11 sharafian

Only admins can update the balance manually, presumably so that they can set up accounts.

sentientwaffle avatar Nov 23 '16 18:11 sentientwaffle

A better way to set up accounts is to create an "issuing" account with minimum_allowed_balance set to -infinity.

That way the balances on the ledger always sum to zero, which is a nice sanity check.

So I'm in favor of removing direct balance setting even by admins.

justmoon avatar Nov 26 '16 05:11 justmoon