interbtc-ui icon indicating copy to clipboard operation
interbtc-ui copied to clipboard

RPC errors crash the UI

Open tomjeatt opened this issue 2 years ago • 2 comments

Describe the bug Unhandled RPC errors crash the UI

To Reproduce Steps to reproduce the behavior:

  1. Go to staking page
  2. Add an amount greater than your balance to the staking amount field
  3. Wait for UI to crash

Expected behavior We should handled RPC errors more gracefully, but this is a long-standing issue. The staking UI is an obvious example, but the error itself is thrown in the generic fetcher and will happen any time we receive an RPC error.

This is a long-standing issue, and should be handled across the application. Most RPC errors are handled in the lib, so users won't see them very often. We should fix this, but by improving error handling across the site.

tomjeatt avatar Apr 21 '23 12:04 tomjeatt

@danielsimao can you take a look at this, and confirm whether any pages other than staking have unhandled RPC errors? Once we know that, we can decide whether we need to handle this as a separate task, or whether it can wait until the staking page is refactored (in which case the problem goes away).

tomjeatt avatar Jul 26 '23 10:07 tomjeatt

Won't fix this now—can't replicate, and the utility which fails to handle the error is being phased out so reducing priority to low. I'll leave the ticket open for information only, as it's possible that the unhandled error will be seen in the UI again.

tomjeatt avatar Aug 02 '23 08:08 tomjeatt