intercom-node icon indicating copy to clipboard operation
intercom-node copied to clipboard

client.companies.update does not update anything

Open JulienZD opened this issue 8 months ago • 0 comments

Affected versions: 6.0+

Problem

When I try to update a company using client.companies.update, nothing gets changed in Intercom.

As previously noted in #465, the typing only accepts a company_id. I figured this would just be an incorrect type definition, but it seems like the entire payload is just not being sent to the API.

Looking at the code for client.companies.update, the company_id is destructured from request, after which the request object isn't used further. Looking at other client implementations, most other update or createOrUpdate methods in the SDK seem to use (a part of) the request object as the body for the request.

I think the underlying issue is that the Intercom documentation itself is incorrect, since the "Update a company" doesn't list a request body at all. My assumption is that Fern uses this incorrect specification to create a broken SDK.

For reference, the "Update a contact" documentation does list a request body:


We decided to stay on v5.0.0 for the time being, since we can't know for certain that all endpoints are properly functioning/documented.

JulienZD avatar Mar 26 '25 14:03 JulienZD