intercom-node icon indicating copy to clipboard operation
intercom-node copied to clipboard

Creating and Updating a Company - only companyId should be required

Open akherr opened this issue 2 years ago • 0 comments

Version info

  • intercom-node version: 4.0.0
  • Node version: 16

Expected behavior

Using the create and update methods for the Company model should only require companyId.

Actual behavior

All of the parameters in the create and update methods for the Company are required.

interface CreateCompanyData {
    createdAt: Timestamp;
    companyId: string;
    name: string;
    monthlySpend: number;
    plan: string;
    size: number;
    website: string;
    industry: string;
    customAttributes: JavascriptObject;
}
declare type UpdateCompanyData = CreateCompanyData;

This interface should reflect what is defined in the API docs, with having all but companyId optional.

akherr avatar Aug 03 '23 20:08 akherr