intercom-java icon indicating copy to clipboard operation
intercom-java copied to clipboard

Add conversation participants support

Open thewheat opened this issue 6 years ago • 3 comments

Adding support for adding and removing of participants from group conversations

  • Created a Participant class as we're using Customer in the response for conversations ratings https://github.com/intercom/intercom-java/pull/235 and also in the return response for the added methods
  • Open to feedback on a better approach for this

image

Related Docs:

  • https://developers.intercom.com/intercom-api-reference/reference#adding-to-group-conversations-as-admin
  • https://developers.intercom.com/intercom-api-reference/reference#adding-to-group-conversations-as-customer
  • https://developers.intercom.com/intercom-api-reference/reference#deleting-from-group-conversations

thewheat avatar Oct 27 '18 11:10 thewheat

Should not be merged as it breaks Tag.delete due to this change https://github.com/intercom/intercom-java/pull/241/files#r228734640 Will need to rethink this a bit more but also open for discussion regarding Customer and Participant calsses

thewheat avatar Oct 28 '18 05:10 thewheat

@thewheat ok .. will leave this for now and focus on other open PRs

choran avatar Nov 02 '18 15:11 choran

For reference PR to parse DELETE requests handled here https://github.com/intercom/intercom-java/pull/248

Will need to merge that first before merging this

thewheat avatar Nov 05 '18 03:11 thewheat