intercity-next
intercity-next copied to clipboard
intercity
Allow fully destroying of an app
Currently when removing an app we only remove it from the Intercity instance dashboard, but not from the Dokku on the actual server.
I got a user question why this was and perhaps we can use this issue to find a good way to truly destroy the data and availability of an app when removing it from Intercity.
We don't want people accidentally destroy their app from Intercity. Maybe we can have a "trashed" state in Intercity dashboard. Only a trashed app can be fully removed from the server via "dokku apps:remove".
An alternative would be to have new options for a regular active app in Intercity instance:
- Disable hosting/make unavailable
- Destroy all data
We do actually remove the app from the Dokku instance. So this is a bug if that is not happening. See: https://github.com/intercity/intercity-next/blob/master/app/jobs/remove_app_job.rb
Ok thanks. Let me try and get a bit more details about this case. Perhaps it's something to do with app naming or a Sidekiq error.
There were no sidekiq errors and the app was called "test", so no problems there. In think it was because removing the app from Dokku takes a while. The user told me the second time it worked.
I think this is not a crashed bug but more some UI to fix that we should display some kind of "removing app" spinner during app destroy and after that is finished hide it.